ref: Convert SentryFeedbackAPI to Swift #6864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6864 +/- ##
=============================================
+ Coverage 84.650% 84.840% +0.190%
=============================================
Files 452 453 +1
Lines 27603 27607 +4
Branches 12098 12103 +5
=============================================
+ Hits 23366 23422 +56
+ Misses 4191 4141 -50
+ Partials 46 44 -2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
noahsmartin
force-pushed
the
updatePublicSwift
branch
from
6db44d5 to
ed5024e
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1339919 | 1214.82 ms | 1238.98 ms | 24.16 ms |
| 319fb1e | 1219.48 ms | 1242.69 ms | 23.21 ms |
| 3ec47ae | 1231.02 ms | 1256.67 ms | 25.65 ms |
| e58d7bf | 1219.98 ms | 1242.39 ms | 22.41 ms |
| 85f7349 | 1232.28 ms | 1248.27 ms | 15.98 ms |
| 7f26f16 | 1220.62 ms | 1255.04 ms | 34.42 ms |
| 119ab1c | 1226.79 ms | 1254.55 ms | 27.76 ms |
| 1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
| 139db8b | 1231.50 ms | 1258.19 ms | 26.69 ms |
| a4c5ddc | 1239.61 ms | 1266.41 ms | 26.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1339919 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 319fb1e | 23.75 KiB | 1019.18 KiB | 995.43 KiB |
| 3ec47ae | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| e58d7bf | 24.15 KiB | 1.01 MiB | 1014.91 KiB |
| 85f7349 | 23.75 KiB | 1.01 MiB | 1006.48 KiB |
| 7f26f16 | 23.75 KiB | 1.02 MiB | 1016.66 KiB |
| 119ab1c | 23.75 KiB | 993.70 KiB | 969.95 KiB |
| 1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 139db8b | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| a4c5ddc | 23.75 KiB | 977.30 KiB | 953.55 KiB |
noahsmartin
force-pushed
the
updatePublicSwift
branch
from
ed5024e to
02a1c4e
Compare
philprime
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just converts this class to Swift. I'll get rid of the wrapper in a follow up PR after converting the Integration class to Swift
#skip-changelog
Closes #6865